Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow backtick, single, and double quotes for PR titles in the doc-changelog action #484

Merged
merged 16 commits into from
May 8, 2024

Conversation

klmcadams
Copy link
Contributor

Use python to remove extra whitespace from a pull request title and allow backticks, single quotes, and double quotes to be included in the towncrier fragment file.

Fragment file in PR with backtick, single and double quotes

Title before extra whitespaces are removed

Closes #479

@klmcadams klmcadams requested a review from a team as a code owner May 7, 2024 18:11
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label May 7, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments - other than that, LGTM

doc-changelog/action.yml Show resolved Hide resolved
doc-changelog/action.yml Outdated Show resolved Hide resolved
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klmcadams klmcadams merged commit ab84a38 into main May 8, 2024
16 checks passed
@klmcadams klmcadams deleted the fix/doc-changelog-single-quote branch May 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc-changelog action fails if PR title contains an apostrophe
2 participants